search

rustwasm / book

The Rust and WebAssembly Book
https://rustwasm.github.io/docs/book/
MIT License
1.73k stars 208 forks source link

Latest code from template not use in book #187

Open austbot opened 5 years ago

austbot commented 5 years ago

Where in the docs did you come across this? https://rustwasm.github.io/docs/book/game-of-life/hello-world.html Describe what about it does not make sense The first code example has the cfg_if macro, but the latest code at https://github.com/rustwasm/wasm-pack-template/blob/master/src/lib.rs does not use it. Why does it not make sense? Because the latest code is not being used/ How could we improve it? I will do a PR, but I'm putting this issue to check if I am correct.

ThePuzzlemaker commented 4 years ago

I did make sure that the templates were updated in #238. I didn't see it in the latest version of the book, but if it was present, it's gone. I assume another PR fixed it but this issue wasn't closed with it.