search

rustwasm / walrus

Walrus is a WebAssembly transformation library 🌊🐘
https://docs.rs/walrus
Apache License 2.0
405 stars 62 forks source link

feat: dwarf code address mapping #244

Closed guybedford closed 1 year ago

guybedford commented 1 year ago

This is a rebase of the PR at https://github.com/rustwasm/walrus/pull/231 to the current main branch, created by @nokotan.

I didn't want to push over that branch, especially since it seems to be in use in various integration attempts. From the description there -

This is experiment implementation of transforming DWARF debug entries in WebAssembly binaries.

It seems to require more difficult implementation that using intermediate DWARF expression with gimli.rs, does not have direct access DWARF entries to be written. This PR contains simpler way to transform code address:

Milestones

daxpedda commented 1 year ago

Cc https://github.com/rustwasm/wasm-bindgen/pull/3483#issuecomment-1595741387. We hit some debug_assert!s in wasm-bindgen when trying out walrus v0.20.

guybedford commented 1 year ago

Thanks for the report, I can try and take a look in the next few days.

guybedford commented 1 year ago

Hey @daxpedda I had a brief look at this today and can confirm it seems an important offset issue that was also present in the original PR. I've posted https://github.com/rustwasm/walrus/issues/247 from some very initial debugging. My hope in shipping was exactly to find bugs... the next hope is to find contributors interested in solving them! If I have time, I'll definitely investigate further too, but can't guarantee anything soon unfortunately.

daxpedda commented 1 year ago

My hope in shipping was exactly to find bugs... the next hope is to find contributors interested in solving them!

Unfortunately I already have a tower of things I have to chew through right now, so as much as I would like to contribute I probably won't get to it.

If I have time, I'll definitely investigate further too, but can't guarantee anything soon unfortunately.

Thank you for your amazing work, I appreciate that you have found time for this so far, no guarantees necessary :heart:.