rustwasm / wee_alloc

The Wasm-Enabled, Elfin Allocator
Mozilla Public License 2.0
666 stars 49 forks source link

This repo needs to be archived and marked as deprecated #109

Open spencerbart opened 1 year ago

spencerbart commented 1 year ago

Too many sites are recommending this repo but this repo has major security issues. It needs to be fixed or taken down.

erwanvivien commented 1 year ago

Agreed

jack-mil commented 1 year ago

Yes I am beginning to see that a lot of the the Rust wasm ecosystem is outdated and not working well in 2023. Specifically the tutorials and book provided from https://rustwasm.github.io/ has not been updated for years and does not work out of the box. What is the modern tooling for wasm with rust, besides wasm-pack and friends?

FlogramMatt commented 1 year ago

Major security issue? You mean the memory leak? You do realize it's impossible to free wasm memory.. I would say this is a wasm issue not this library. I bet the standard allocator has the same issue..

erwanvivien commented 1 year ago

https://github.com/rustwasm/wee_alloc/issues/106#issue-1179853771

Making two large allocations, then dropping them in the order they were allocated leaks memory in wee_alloc, but not in default allocator.

Hello @FlogramMatt. I believe not, this issue says otherwise