search

rustwasm / wee_alloc

The Wasm-Enabled, Elfin Allocator
Mozilla Public License 2.0
665 stars 49 forks source link

CI should be running tests #72

Closed RReverser closed 5 years ago

RReverser commented 5 years ago

Looks like tests are currently failing on master on Unix/Windows, and it's easy to miss because CI runs just cargo check.

pepyakin commented 5 years ago

Hm, why do you think that?

As far as I understand ./test.sh also runs. It is set up as a test matrix here

https://github.com/rustwasm/wee_alloc/blob/90e09bc22be4cc97e210218ec7611f651e559622/.travis.yml#L9-L11

and here is an example of a test run

RReverser commented 5 years ago

Hmm how was #69 not caught by CI then? Doesn't seem anything platform-specific. And after that I found one more doc-test failure too, not reported yet.

fitzgen commented 5 years ago

The tests are running: https://travis-ci.org/rustwasm/wee_alloc/jobs/461412347#L479-L941

I'm not sure what was up with the layout thing, but it might have had to do with the cargo features bug.

RReverser commented 5 years ago

Hmm, that could be it...

fitzgen commented 5 years ago

I think we are only testing teh test crate in CI, not the wee_alloc crate itself (which only has a couple little tests). I'll whip up a PR.

RReverser commented 5 years ago

Ah that explains it.