search

rustwasm / wee_alloc

The Wasm-Enabled, Elfin Allocator
Mozilla Public License 2.0
666 stars 49 forks source link

Remove no-longer-needed nightly feature #74

Closed alexcrichton closed 5 years ago

alexcrichton commented 5 years ago

Wasm intrinsics are stabilized now!

ZackPierce commented 5 years ago

I think we're currently at the point where the status quo compiles on stable, but not on nightly due to the upcoming API change related to this PR. Accepting this PR would most likely make weealloc compile on nightly, but not on stable. ¯_(ツ)/¯

We could add an intermediate PR that uses cfg-flags to support both patterns, though it would have to be torn out once stable catches up to nightly.

What do you think, @fitzgen ?

fitzgen commented 5 years ago

Accepting this PR would most likely make weealloc compile on nightly, but not on stable. ¯(ツ)_/¯

The wasm intrinsics were nightly-only anyways, so stable already didn't work with wasm. Given that, this is a "fix" where nightly stopped working because of the rename, and now it will work again. Then, as rustc release trains keep chugging along, beta and stable will start working with wasm as well.

Stable should continue to work for non-wasm platforms like it does now for sure!