search

rusty1s / pytorch_cluster

PyTorch Extension Library of Optimized Graph Cluster Algorithms
MIT License
778 stars 141 forks source link

random_walk result not reproducible if the walk is biased #195

Open jsun57 opened 8 months ago

jsun57 commented 8 months ago

As title. The issue comes from https://github.com/rusty1s/pytorch_cluster/blob/29cd22bf1a5b82fc06b108d6573f81302c5d6b12/csrc/cuda/rw_cuda.cu#L146, where the seed is controlled by time(NULL) in rejection_sampling_kernel function. Please fix~

rusty1s commented 8 months ago

Can you send a PR to fix this?

jsun57 commented 8 months ago

While I can locate the issue, unfortunately I only have access to a university cluster which does not have nvcc installed... So I am not able to build from source to perform testing sadly

rusty1s commented 8 months ago

Ok, I see if I can find time to implement this.

jsun57 commented 7 months ago

Wondering if there are any updates on this

jsun57 commented 6 months ago

Wondering if there are any updates on this~

rusty1s commented 6 months ago

Not yet, sorry :(

jsun57 commented 3 months ago

Would like to know if we have any updates.

jsun57 commented 2 months ago

Would like to know if we have any updates.