GericoVi
commented
6 days ago Update, both C++17 and C++14 compilation actually does work when linking to PyTorch 1.13.1 for example. Unsure, which version is the breaking point, just adding this here for reference.
Hi, I'm trying to compile the code on Windows using MSVC 2019. It seems that PyTorch 2 requires C++17 now, so if you want to build this repo for that using CMake I think line 3 in
CMakeLists.txtshould be changed fromset(CMAKE_CXX_STANDARD 14)toset(CMAKE_CXX_STANDARD 17). The former is fine when linking PyTorch 1.8.0 for example but doesn't work for PyTorch 2.2.2 for example unless C++17 is used.Presumably, the compilation on the python side doesn't use the
CMakeLists.txtand provides it's own compiler arguments to use C++17? But when compiling it manually this seems to come up.However, leaving
set(CMAKE_CXX_STANDARD 17)but trying to compile with PyTorch 1.8.0 does not seem to work. With many of the same error but an example snippet is:Note that the same thing is true when trying to compile on MacOS with CMake (like in this example). In this case the error is pretty clear and suggests C++17:
This is perhaps a PyTorch issue? But maybe a conditional in the
CMakeLists.txtthat uses either 14 or 17 depending on the libtorch version could work? Or just exposing this as a CMake variable?Any thoughts on this?