search

rusty1s / pytorch_spline_conv

Implementation of the Spline-Based Convolution Operator of SplineCNN in PyTorch
https://arxiv.org/abs/1711.08920
MIT License
172 stars 36 forks source link

Unclear installation instructions #52

Closed adamjstewart closed 5 months ago

adamjstewart commented 5 months ago

The README says to set TORCH_CUDA_ARCH_LIST, however setup.py only respects NVCC_FLAGS.

adamjstewart commented 5 months ago

Ah, I was mistaken. 1.2.0 injected flags like -arch=sm_35 into the build even when TORCH_CUDA_ARCH_LIST was set differently. However, it looks like 1.2.2 no longer has this issue, and even though the variable isn't referenced directly in the source code, it's used in torch/utils/cpp_extension.py. False alarm!