search

rustybird / corridor

Tor traffic whitelisting gateway
ISC License
68 stars 6 forks source link

don't enforce /usr/local, allow variables being overwritten #36

Closed adrelanos closed 7 years ago

rustybird commented 7 years ago

?= is a GNUism, right? I don't know how well that would work with other make implementations. Why not use the conventional way to override Makefile variables:

make PREFIX=/usr DESTDIR=/tmp/corridor install install-systemd
adrelanos commented 7 years ago

Rusty Bird:

?= is a GNUism, right?

No idea. Never used a non-GNU make.

I don't know how well that would work with other make implementations. Why not use the conventional way to override Makefile variables:

make PREFIX=/usr DESTDIR=/tmp/corridor install install-systemd

Because that doesn't work without ?=. Didn't work for me. Hence I suggested the ?=. Looks like like just = sets the variable no matter what the environment has set.

rustybird commented 7 years ago 
make PREFIX=/usr DESTDIR=/tmp/corridor install install-systemd

Because that doesn't work without ?=

It definitely should. You probably have a mismatch between the PREFIX you are passing (or not) to one of the build targets vs. one of the install targets. (If it's a problem during testing, the build directory might be dirty.)

adrelanos commented 7 years ago

My mistake. It does.