search

rustyhorde / vergen

Generate cargo instructions at compile time in build scripts for use with the env! or option_env! macros
Apache License 2.0
370 stars 55 forks source link

Complete implementation for VERGEN_GIT_DIRTY #283

Closed CraZySacX closed 7 months ago

CraZySacX commented 7 months ago

Continuation of https://github.com/rustyhorde/vergen/pull/281

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (a63aca1) 96.99% compared to head (0bda857) 97.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #283 +/- ## ========================================== + Coverage 96.99% 97.94% +0.95% ========================================== Files 23 24 +1 Lines 1628 1608 -20 ========================================== - Hits 1579 1575 -4 + Misses 49 33 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hgomersall commented 7 months ago

It looks like drop on TestRepo has the clean up of self.clone_path still commented out.

hgomersall commented 7 months ago

Thanks for committing this and your help in getting it merged!

CraZySacX commented 7 months ago

It looks like drop on TestRepo has the clean up of self.clone_path still commented out.

Yep, thanks for the catch, pushing up the fix now. Shouldn't affect the release because that's test only code, so I won't be cutting a new release.