search

rustymotors / rusty

GNU General Public License v3.0
0 stars 0 forks source link

Drazisil/issue39 #40

Closed drazisil closed 3 months ago

drazisil commented 3 months ago

The Session model and its associated attributes and types have been added to the web library. This allows for the creation and management of sessions in the application. The necessary exports have also been added to the index file for easy access. This change enhances the functionality of the web library by introducing session management capabilities.

coderabbitai[bot] commented 3 months ago

[!IMPORTANT]

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
nx-cloud[bot] commented 3 months ago

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6848463adcb9fccf6efc784b138f09b34a1ddd39. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target - [`nx affected -t lint test build`](https://cloud.nx.app/runs/BshR1kbzHq?utm_source=pull-request&utm_medium=comment)

Sent with 💌 from NxCloud.

drazisil commented 3 months ago

@drazisil-codecov Why is this being marked a tokenless upload?

https://github.com/rustymotors/rusty/actions/runs/10180114170/job/28157297339?pr=40#step:9:76

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 38.88889% with 33 lines in your changes missing coverage. Please review.

Project coverage is 31.19%. Comparing base (3a5f229) to head (6848463).

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
libs/web/src/models/Session.ts 0.00% 33 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #40 +/- ## =========================================== + Coverage 29.27% 31.19% +1.91% =========================================== Files 28 30 +2 Lines 608 638 +30 Branches 50 52 +2 =========================================== + Hits 178 199 +21 - Misses 430 439 +9 ``` | [Flag](https://app.codecov.io/gh/rustymotors/rusty/pull/40/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | Coverage Δ | | |---|---|---| | [Config](https://app.codecov.io/gh/rustymotors/rusty/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `31.19% <38.88%> (+1.91%)` | :arrow_up: | | [Server](https://app.codecov.io/gh/rustymotors/rusty/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `31.19% <38.88%> (+1.91%)` | :arrow_up: | | [Utils](https://app.codecov.io/gh/rustymotors/rusty/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `31.19% <38.88%> (+1.91%)` | :arrow_up: | | [Web](https://app.codecov.io/gh/rustymotors/rusty/pull/40/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `31.19% <38.88%> (+1.91%)` | :arrow_up: | | [Components](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=components&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | Coverage Δ | | |---|---|---| | [Server](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `5.05% <ø> (+0.34%)` | :arrow_up: | | [Config](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `16.66% <ø> (ø)` | | | [Web](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `7.97% <0.00%> (-1.40%)` | :arrow_down: | | [Utils](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `0.00% <ø> (ø)` | | | [All Tests](https://app.codecov.io/gh/rustymotors/rusty/pull/40/components?src=pr&el=component&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | `98.83% <100.00%> (+0.16%)` | :arrow_up: | | [Files](https://app.codecov.io/gh/rustymotors/rusty/pull/40?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) | Coverage Δ | | |---|---|---| | [libs/web/index.ts](https://app.codecov.io/gh/rustymotors/rusty/pull/40?src=pr&el=tree&filepath=libs%2Fweb%2Findex.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors#diff-bGlicy93ZWIvaW5kZXgudHM=) | `0.00% <ø> (ø)` | | | [libs/web/test/Session.test.ts](https://app.codecov.io/gh/rustymotors/rusty/pull/40?src=pr&el=tree&filepath=libs%2Fweb%2Ftest%2FSession.test.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors#diff-bGlicy93ZWIvdGVzdC9TZXNzaW9uLnRlc3QudHM=) | `100.00% <100.00%> (ø)` | | | [libs/web/src/models/Session.ts](https://app.codecov.io/gh/rustymotors/rusty/pull/40?src=pr&el=tree&filepath=libs%2Fweb%2Fsrc%2Fmodels%2FSession.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors#diff-bGlicy93ZWIvc3JjL21vZGVscy9TZXNzaW9uLnRz) | `0.00% <0.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/rustymotors/rusty/pull/40/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/rustymotors/rusty/pull/40?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/rustymotors/rusty/pull/40?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors). Last update [3a5f229...6848463](https://app.codecov.io/gh/rustymotors/rusty/pull/40?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=rustymotors).