Tilling not really working when moving windows to other workspaces

rustysec / tidalwm

Simple and sane tiling window manager for Gnome Shell

GNU General Public License v3.0

194 stars 5 forks source link

Tilling not really working when moving windows to other workspaces #20

Closed REIS0 closed 4 years ago

REIS0 commented 4 years ago

I've found something interesting, when I open two apps in one workspace, move one of them to the workspace below, and go back to the first workspace, the app that stayed in the first workspace don't resize.

example here with firefox

Steps to reproduce:

Open one app in a workspace, let's say workspace 1
Open a second app in worskpace 1
Move one of the apps to the workspace below, we can call it workspace 2, using keyboard shortcut (in my case is Super+Shift+Down)
The app in the workspace 2 is resized as it should, however the app in workspace 1 stays as it was when it had a second app. (sometimes it happens that both don't resize)

Tested with different apps, using gtk or not, and could reproduce it without problems, looks like it's related to the new dynamic workspace support.

rustysec commented 4 years ago

This looks like a regression from dynamic workspace support, don't know how i didn't catch it before.

rustysec commented 4 years ago

just push a large change that should fix a few issues.

Edit: still having a couple issues... sorting those out.

rustysec commented 4 years ago

Another sizable change, I'm still able to trigger a weird "remains as the original size" bug occasionally, but I have an idea what is going on. The stability of the current version should :+1:, however

REIS0 commented 4 years ago

Sometimes this bug also happens to me, mostly when I move apps between my monitor, just closing them and opening again fix it

EDIT: fix bad typing

EDIT 2: this bug can also be related to causing #13 sometimes, so maybe when this is fixed the other one possibly stops happening at least for me

rustysec commented 4 years ago

i can usually grab the window, move it a little, then it resets correctly.

REIS0 commented 4 years ago

One more thing to add, the command to rotate windows isn't working, tried using other keys but nothing, while the command to make the window float works

REIS0 commented 4 years ago

I'm gonna close this one since there's already another issue related to "original size" bug #21

rustysec commented 4 years ago

One more thing to add, the command to rotate windows isn't working, tried using other keys but nothing, while the command to make the window float works

Basically my dynamic workspace merge broke everything (:sob:), but I have a new branch where everything will be much better than before. Basically gutted all the internals with some lessons learned from all these bugs. The gnome docs on extensions aren't what I'd call excellent.

REIS0 commented 4 years ago

I've been trying to read the beginners part of it and can't agree more