search

rustysec / tidalwm

Simple and sane tiling window manager for Gnome Shell
GNU General Public License v3.0
192 stars 5 forks source link

Select window shortcuts not working after last commits #34

Closed REIS0 closed 4 years ago

REIS0 commented 4 years ago

Basically the shortcuts don't work and after trying in another computer with a later version I've discovered that could be related to last commit, now I've rolled back to commit a9d34484c0cd52ba445996482adbd2e236aa074e which they're working without problems.

rustysec commented 4 years ago

That's odd, I'm using it right now... Wonder what could be wrong. I can possibly dig in tonight.

rustysec commented 4 years ago

What are your mappings?

REIS0 commented 4 years ago

I've changed the < Super > to < Control >< Alt > in them since it collides with the Pop_OS! shortcuts

EDIT: now showing the shortcuts

rustysec commented 4 years ago

Are they working now?

REIS0 commented 4 years ago

Yes, I'm gonna close this one

rustysec commented 4 years ago

Awesome, glad to hear it.

REIS0 commented 4 years ago

false positive, the problem is back, looks like I was dumb and didn't updated properly the extensions and it was on the old commit.

rustysec commented 4 years ago

What do you have them mapped to? I have <Super>Left,<Super>h for "Select window left", for instance. Similar vim keys for the other directions and it's currently working for me.

I'm guessing either the mapping is not input correctly, or it's conflicting with some other system setting?

rustysec commented 4 years ago

Also if you run journalctl -xf /usr/bin/gnome-shell while trying to use the shortcuts, you can see any errors that might be getting thrown in the background.

REIS0 commented 4 years ago

Here's the output

-- Logs begin at Sat 2020-01-25 21:17:55 -03. --
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 35 with keysym 35 (keycode e).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 39 with keysym 39 (keycode 12).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 36 with keysym 36 (keycode f).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 33 with keysym 33 (keycode c).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 38 with keysym 38 (keycode 11).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 34 with keysym 34 (keycode d).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 37 with keysym 37 (keycode 10).
Feb 16 23:53:46 pop-os gnome-shell[6846]: Window manager warning: Overwriting existing binding of keysym 31 with keysym 31 (keycode a).
Feb 16 23:53:47 pop-os gnome-shell[6846]: spiral.js: adding window 3225015042 to spiral 0, 0
Feb 16 23:53:48 pop-os gnome-shell[6846]: spiral.js: adding window 3225015043 to spiral 0, 0
Feb 16 23:54:00 pop-os gnome-shell[6846]: Usage of object.actor is deprecated for ButtonBox
                                          get@resource:///org/gnome/shell/ui/environment.js:249:29
                                          onTrayIconAdded/<@/home/arthur/.local/share/gnome-shell/extensions/tray-icons@zhangkaizhao.com/extension.js:68:9
Feb 16 23:54:34 pop-os gnome-shell[6846]: spiral.js: adding window 3225015045 to spiral 1, 0
Feb 16 23:54:46 pop-os org.gnome.tweaks.desktop[6846]: WARNING : Error loading desktopfile: /home/arthur/.config/autostart/redshift-gtk.desktop
Feb 16 23:54:47 pop-os gnome-shell[6846]: spiral.js: adding window 3225015046 to spiral 2, 0
Feb 16 23:54:51 pop-os gnome-shell[6846]: Window manager warning: Buggy client sent a _NET_ACTIVE_WINDOW message with a timestamp of 0 for 0x6400007

and here's my keybindings image

as I said for some reason rolling back to older commit makes it work, I'm gonna roll back and paste the output here

EDIT: output when using version from commit a9d34484c0cd52ba445996482adbd2e236aa074e

-- Logs begin at Sat 2020-01-25 21:17:55 -03. --
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 39 with keysym 39 (keycode 12).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 32 with keysym 32 (keycode b).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 37 with keysym 37 (keycode 10).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 33 with keysym 33 (keycode c).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 31 with keysym 31 (keycode a).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 38 with keysym 38 (keycode 11).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 36 with keysym 36 (keycode f).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Window manager warning: Overwriting existing binding of keysym 34 with keysym 34 (keycode d).
Feb 16 23:59:28 pop-os gnome-shell[10939]: Usage of object.actor is deprecated for ButtonBox
                                           get@resource:///org/gnome/shell/ui/environment.js:249:29
                                           onTrayIconAdded/<@/home/arthur/.local/share/gnome-shell/extensions/tray-icons@zhangkaizhao.com/extension.js:68:9
Feb 16 23:59:28 pop-os gnome-shell[10939]: spiral.js: adding window 1769152113 to spiral 0, 0
Feb 16 23:59:37 pop-os gnome-shell[10939]: spiral.js: adding window 1769152114 to spiral 0, 0
Feb 16 23:59:48 pop-os gnome-shell[10939]: JS WARNING: [/home/arthur/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js 1440]: reference to undefined property "_settings"
Feb 16 23:59:48 pop-os gnome-shell[10939]: JS ERROR: TypeError: dock._settings is undefined
                                           _showOverlay@/home/arthur/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:1440:1
                                           _enableHotKeys/</<@/home/arthur/.local/share/gnome-shell/extensions/dash-to-dock@micxgx.gmail.com/docking.js:1366:43
Feb 16 23:59:50 pop-os gnome-shell[10939]: spiral.js: adding window 1769152115 to spiral 1, 0
Feb 17 00:00:26 pop-os gnome-shell[10939]: Usage of object.actor is deprecated for ButtonBox
                                           get@resource:///org/gnome/shell/ui/environment.js:249:29
                                           onTrayIconAdded/<@/home/arthur/.local/share/gnome-shell/extensions/tray-icons@zhangkaizhao.com/extension.js:68:9
rustysec commented 4 years ago

What other extensions do you have installed? Dash to panel? Do you use multiple monitors?

REIS0 commented 4 years ago

Besides the one that already come with Pop_OS!, I have: dash to dock, caffeine, workspace switcher, tray icons, notification remover.

rustysec commented 4 years ago

Ok, I'll try to reproduce with dash to dock and see where that gets me. Thanks for the info.

rustysec commented 4 years ago

I set my keybindings to yours and there is definitely something odd happening. The defaults work fine, but getting inconsistent results with <Control><Alt>Arrow might be something conflicting... and it doesn't seem to be related to dash to panel.

rustysec commented 4 years ago

Aha, I bet your gaps are set to 0, right?

rustysec commented 4 years ago

Thanks for the bug report, that was a silly oversight on my part.