search

rutgerkok / BlockLocker

Protect chests, doors and other blocks in Minecraft from being opened using protection signs
https://www.spigotmc.org/resources/blocklocker.3268/
MIT License
69 stars 43 forks source link

Slimefun/BlockLocker duplication issue #121

Closed Sfiguz7 closed 3 years ago

Sfiguz7 commented 3 years ago

A new issue has just been opened on the Slimefun GitHub about a method through which Slimefun Items can be duplicated. As I commented down there, this is likely due to conflicts in the way Slimefun and BlockLocker handle BlockPlaceEvents.

I have found no better place to bring this up other than here (Spigot DMs would be hidden to others having the same issue) so I decided to open this, to see if you could help us by pointing out which classes we would be likely to find these conflicts in as, although the code is opensource, you definitely know it better than we do: I am sure this will speed the testing/fixing process, and I thank you in advance for it.

If you would rather discuss this elsewhere, feel free to contact me via Discord (Sfiguz7#7063) or join our Slimefun Discord (https://discord.gg/slimefun) so that a more thorough conversation can be had. Thank you again!

rutgerkok commented 3 years ago

Should be fixed now. BlockLocker fires a BlockPlaceEvent when auto-placing a sign, but up until now it just always reported the main hand as being used, even when a player used the off hand.

Thanks for reporting!

JustinDevB commented 2 years ago

This issue is not fixed

Skizzles commented 2 years ago

@rutgerkok This issue is still not resolved.