search

rutgerkok / BlockLocker

Protect chests, doors and other blocks in Minecraft from being opened using protection signs
https://www.spigotmc.org/resources/blocklocker.3268/
MIT License
69 stars 43 forks source link

[Bug] SimpleClans group system allows all players to access privated items #150

Closed Firav closed 1 year ago

Firav commented 2 years ago

When using the group tag on a chest, in this case [Unitum], all players can access the chest whether they are in the group or not.

Thrown Error:

Error stack [15:10:47 ERROR]: Could not pass event PlayerInteractEvent to BlockLocker v1.11 java.lang.NullPointerException: Cannot invoke "net.sacredlabyrinth.phaed.simpleclans.ClanPlayer.getClan()" because "clanPlayer" is null at nl.rutgerkok.blocklocker.impl.group.SimpleClansGroupSystem.isInGroup(SimpleClansGroupSystem.java:49) ~[BlockLocker_1.11.jar:?] at nl.rutgerkok.blocklocker.group.CombinedGroupSystem.isInGroup(CombinedGroupSystem.java:82) ~[BlockLocker_1.11.jar:?] at nl.rutgerkok.blocklocker.impl.profile.GroupProfileImpl.includes(GroupProfileImpl.java:89) ~[BlockLocker_1.11.jar:?] at nl.rutgerkok.blocklocker.impl.protection.AbstractProtection.isAllowed(AbstractProtection.java:157) ~[BlockLocker_1.11.jar:?] at nl.rutgerkok.blocklocker.impl.event.InteractListener.checkAllowed(InteractListener.java:107) ~[BlockLocker_1.11.jar:?] at nl.rutgerkok.blocklocker.impl.event.InteractListener.onPlayerInteract(InteractListener.java:328) ~[BlockLocker_1.11.jar:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor11.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:75) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:git-Paper-131] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:670) ~[paper-api-1.19.2-R0.1-SNAPSHOT.jar:?] at org.bukkit.craftbukkit.v1_19_R1.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:544) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.server.level.ServerPlayerGameMode.useItemOn(ServerPlayerGameMode.java:525) ~[?:?] at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItemOn(ServerGamePacketListenerImpl.java:1974) ~[?:?] at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:37) ~[?:?] at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.a(ServerboundUseItemOnPacket.java:9) ~[?:?] at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$1(PacketUtils.java:51) ~[?:?] at net.minecraft.server.TickTask.run(TickTask.java:18) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:153) ~[?:?] at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[?:?] at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1360) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.server.MinecraftServer.d(MinecraftServer.java:185) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:126) ~[?:?] at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1337) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1330) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:114) ~[?:?] at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1464) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1192) ~[paper-1.19.2.jar:git-Paper-131] at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:305) ~[paper-1.19.2.jar:git-Paper-131] at java.lang.Thread.run(Thread.java:833) ~[?:?]

Screenshot: Screenshot

Versions: git-Paper-131 (1.19.2) BlockLocker v1.11 SimpleClans 2.17.0