search

rutgerkok / BlockLocker

Protect chests, doors and other blocks in Minecraft from being opened using protection signs
https://www.spigotmc.org/resources/blocklocker.3268/
MIT License
69 stars 43 forks source link

[Bug] Variable {project.name} doesn't show in the manual update event #158

Closed PetyXbron closed 1 year ago

PetyXbron commented 1 year ago

Hey @rutgerkok, I found a code bug! This is a screenshot of "update alert": (called "update_available" in translations files under "updater" property and also called "MANUAL_UPDATE" as a Java case in the code - UpdateNotifier.java and it may have connections with Translator.java). image Notice: Because the official Czech language (used in the screenshot) was implemented in this new update (v1.12) this bug may be caused because of the manual translations file import but I guess the variable project.name should replace in messages from translations automatically from any translations file. Unfortunately, I have absolute non-experience with Java, so if this is an issue I can't create a pull request with the bug fix.

rutgerkok commented 1 year ago

This placeholder is normally replaced by "BlockLocker" upon compilation of BlockLocker. So the JAR file you download should already have that text replaced.

I quickly downloaded the JAR file from Spigotmc.org, and in there the translation is indeed already replaced. So if you set languageFile: translations-cs.yml in the config.yml of BlockLocker, you should get the correct file.

Maybe you could give me the steps to reproduce? So where should I download BlockLocker from, and what should I set in the config.yml?

PetyXbron commented 1 year ago

Yes, the bug was probably made by the fact, that my language file was not from the plugin because it was uploaded from my computer.