ruuda / claxon

A FLAC decoder in Rust
Apache License 2.0
287 stars 28 forks source link

More portable benchmarking script #15

Closed Shnatsel closed 6 years ago

Shnatsel commented 6 years ago

Look up system-wide time binary instead of hardcoding it to /bin/time; e.g. on Ubuntu it's /usr/bin/time. This made the .sh script work for me.

To get benchmarking working I also had to exclude p0.flac and p1.flac sample files from archive.org because Claxon benchmarking program was panicking on decoding them:

For me this custom R thing is way more trouble than it's worth and I'll just stick to hyperfine "target/release/examples/decode testsamples/extra/*.flac" "flac -fd testsamples/extra/*.flac" which does exactly the same in Rust and without custom scripts. But I thought I'd submit the fix anyway.

ruuda commented 6 years ago

Thanks!