search

ruuda / hound

A wav encoding and decoding library in Rust
https://codeberg.org/ruuda/hound
Apache License 2.0
489 stars 65 forks source link

Replace try! with question mark operator #61

Open yoshinorisano opened 2 years ago

yoshinorisano commented 2 years ago

There are a lot of compiler warnings when building hound:

warning: use of deprecated macro `try`: use the `?` operator instead

So I tried to fix that. Does this make sense to you?

yoshinorisano commented 2 years ago

@ruuda Hi! Could you review this?

atoktoto commented 11 months ago

It would be great if this got merged. I'm working on a no_std support for this library. While I don't expect my changes will ever get merged (I had to switch to nightly) having this accepted would make it easier for me to keep my fork in sync with future changes.

maxtimbo commented 6 months ago

@ruuda Can this be merged?

bbb651 commented 2 months ago

Haven't checked the open PRs and I redid this myself in #83, along with some other things, would be nice to get them merged. I noticed there's this repo and an identical codeberg link to each other, I'm not sure who's the mirror of who, but they both seem inactive