search

ruuda / hound

A wav encoding and decoding library in Rust
https://codeberg.org/ruuda/hound
Apache License 2.0
489 stars 65 forks source link

Proposal to rebase #58 onto 3.5.0 for a new release #68

Closed maxwellmckinnon closed 1 year ago

maxwellmckinnon commented 1 year ago

Work for issue #66 which is just a cherry picking of @spacecams work in #58 on top of 3.5.0.

ruuda commented 1 year ago

Thanks so much for picking this up! I see it’s impossible on GitHub to target a tag with a pull request, so I’ve advanced the release branch to point to 3.5.0, and I also added a rust-toolchain.toml there to make it easier to see what the supported Rust version is.

I thought these changes only required MaybeUninit, which was stabilized in 1.36, but it turns out MaybeUninit::write requires a much newer 1.55, and f32::from_le_bytes requires 1.40. I think 1.40 is still okay to bump the MSRV to, so I did that now. I squashed your commits into one and made sure Cargo.lock remains unchanged aside from the version update.

maxwellmckinnon commented 1 year ago

Amazing, thanks Ruud!