search

ruudverheijden / node-p1-reader

Node.js package for reading and parsing data from the P1 port of a Dutch or Belgian Smart Meter.
MIT License
25 stars 25 forks source link

CRC validation #5

Open timoline opened 7 years ago

timoline commented 7 years ago

Do we need CRC validation?

example code https://github.com/robertklep/node-dsmr-parser

ruudverheijden commented 7 years ago

Didn't know it was in the DSMR specs but I think it's fine to add it ;) Can you make a pull request for it?

timoline commented 7 years ago

I wish I could :-) I'm just a beginner...I mean I tried, but still no succes

timoline commented 6 years ago

found this fork, which implemented crc, maybe you can get the code and implement it? https://github.com/jorith88/node-p1-reader/commits/master

thanks in advanced

ruudverheijden commented 6 years ago

Thanks! Will have a look after my holiday ;)

timoline commented 6 years ago

Hi, can you reopen this one? thx

ruudverheijden commented 6 years ago

Done