Improve accessible labels for screenreader

[ruuen]

Will add to below list as I find them during SR reviews:

• Mobile: open navigation button needs better name.
  • Change from "open menu" to "open site navigation"
  • Maybe nav element needs better accessible name so that it announces "navigation menu" and then "open menu"?
• Dropdown groups can probably have accessible names removed. "Feature pages" might be weird when you know that you're already in a navigation
• Client logos, do they need to be hidden? If not, they need better alt text & the section needs an accessible label

[ruuen]

https://www.w3.org/WAI/ARIA/apg/practices/names-and-descriptions/

[ruuen]

Reviewing online resources & the above authoring guidelines, will make below adjustments:

• Will not rename mobile nav buttons as it makes sense after review and further testing
  • This section in the ARIA APG explains:

    Do NOT include a WAI-ARIA role name in the accessible name. For example, do not include the word button in the name of a button, the word image in the name of an image, or the word navigation in the name of a navigation region. Doing so would create duplicate screen reader output since screen readers convey the role of an element in addition to its name.

  • Renaming to "Open site navigation" contains a role name in the accessible name which is not recommended. SRs already announce the region as navigation, so open menu makes sense.
  • The desktop layout does not render the buttons as the menu is visible on page load, so the links are then browsable after being announced as navigation as well.
• [x] Will remove specified labels from the dropdown groups + add an accessible name to the list of nav links so that it reads like navigation > site pages > features/company/careers/about
  • [x] Need to do the user auth links as well
• [x] A better solution to the client logos would be the list having a label identifying them as clients, then having the client names as alt-text on each image while removing "logo" from the alt text.
• [x] Hide hero image as it is purely decorative

[ruuen]

Added a manual label to the "Todo List" link so that "todo" is pronounced as two separate words more reliably.