ruuen / challenge-dropdown-navigation

Solution for the dropdown navigation challenge on frontendmentor.io
0 stars 0 forks source link

Review if mobile nav close button should be placed above content list #8

Open ruuen opened 12 months ago

ruuen commented 12 months ago

Currently I have the mobile nav close button at the bottom of DOM order, after the links. This seemed to be best practice when reviewing a11y resources, but it does feel a bit strange when actually using it when the screenreader.

Need to do a bit more reading on this point & maybe get some feedback on how other devs approach it if I can't make a decision.

ruuen commented 11 months ago

I can't find anything too definitive online to suggest this is wrong, so going to get feedback from mentors on this one.