ruuk / script.module.youtube.dl

⛔️ DEPRECATED: Access to youtube-dl stream extraction in an XBMC module
GNU General Public License v2.0
39 stars 40 forks source link

Is hasMultipleStreams() function working as intended? #27

Closed Twilight0 closed 6 years ago

Twilight0 commented 6 years ago

As a reference the following line: https://github.com/ruuk/script.module.youtube.dl/blob/master/lib/YoutubeDLWrapper.py#L127

It seems like no matter what is passed into this function it always returns False.

ruuk commented 6 years ago

Before I look at this, I'd like an example of something that definitely has multiple streams not working here. An example of something with multiple streams would be a page that has multiple different trailers (ex. a trailer, an extended trailer and a clip). This is not the same as when you have different quality versions (i.e. 1080p,720p, mp4, DASH, etc.)

Twilight0 commented 6 years ago

I am sorry, I thought it was meant to return True for multiple different qualities.

ruuk commented 6 years ago

No worries :smile: