search

ruuk / script.module.youtube.dl

⛔️ DEPRECATED: Access to youtube-dl stream extraction in an XBMC module
GNU General Public License v2.0
39 stars 40 forks source link

Make script Python 3 compatible #40

Open goggle opened 5 years ago

goggle commented 5 years ago

I'm currently working on making my Kodi plugins to work with Python 3 (see https://kodi.tv/article/attention-addon-developers-migration-python-3). It is suggested to make all the plugins/scripts compatible with both, Python 2 and Python 3, so that the transition will be smooth.

Currently, script.module.youtube.dl does not work with Python 3. On a Python 3 Kodi test build, I get the following error, when I try to import it:

script.module.youtube.dl/lib/YDStreamExtractor.py", line 418
                                                except YoutubeDLWrapper.youtube_dl.DownloadError, e:
                                                                                                ^
                                            SyntaxError: invalid syntax

There are probably many more lines, where the code is not compatible to Python 3.

Is it planned to release script.module.youtube.dl with Python 3 support?

sy6sy2 commented 4 years ago

Hi @ruuk, Are you interested on a PR of your add-on for Python 2 AND 3 compatibility? I am currently working on it.

ruuk commented 4 years ago

A PR would be great!

sy6sy2 commented 4 years ago

A first attempt here https://github.com/ruuk/script.module.youtube.dl/pull/52