search

ruuk / script.module.youtube.dl

⛔️ DEPRECATED: Access to youtube-dl stream extraction in an XBMC module
GNU General Public License v2.0
39 stars 40 forks source link

[fix] Use new abortRequested API #56

Closed sy6sy2 closed 4 years ago

sy6sy2 commented 4 years ago

xbmc.abortRequested is deprecated and we should use xbmc.Monitor().abortRequested() now (see: https://kodi.wiki/view/Service_add-ons).

In addition, there is a bug with xbmc.abortRequested if Youtube-DL is called from a Python add-on that use the reuselanguageinvoker feature ; in this case, xbmc.abortRequested always return True even if Kodi is not exiting.

Conclusion: Youtube-DL is completely broken on Video add-on that use reuselanguageinvoker because we always get a Exception('abortRequested')

sy6sy2 commented 4 years ago

Ping @ruuk 😉

ruuk commented 4 years ago

Thanks!