search

ruuvi / com.ruuvi.station.ios

iOS Ruuvi Station
BSD 3-Clause "New" or "Revised" License
34 stars 21 forks source link

Show alert limits in graphs #1547

Open markoaamunkajo opened 1 year ago

markoaamunkajo commented 1 year ago

Description:

Show alert limits in graphs on history view page in app. Refer to WebUI card for details: https://github.com/ruuvi/com.ruuvi.station.webui/issues/204

Android card: https://github.com/ruuvi/com.ruuvi.station/issues/1063

markoaamunkajo commented 1 year ago

Currently not supported by library, needs internal discussion.

markoaamunkajo commented 9 months ago

@rinat-enikeev please investigate feasability for this on iOS after we have now had codebase improvements this could become important. Not high priority, take a look when you have time.

rinat-enikeev commented 9 months ago

more like investigation atm

markoaamunkajo commented 6 months ago

@rinat-enikeev looks like when I change units the alert limits will act weirdly. Build 2.7.0 (2403311418)

https://github.com/ruuvi/com.ruuvi.station.ios/assets/50437378/f3b9eebc-716d-42b6-90c2-c7676c648290

markoaamunkajo commented 5 months ago

@priyonto but still appears occasionally in UI.

Reproduced by flicking through cards when in history view mode. On one of the cards fill is broken. Also note that the middle chart has thinner line.

https://github.com/ruuvi/com.ruuvi.station.ios/assets/50437378/b00fb9f7-f952-4e79-bb59-14485fedf13f

Here are settings for those particular alerts on the card

Image