search

ruuvi / ruuvi-sensor-protocols

46 stars 20 forks source link

minor value errors #19

Closed NoHalfBits closed 5 years ago

NoHalfBits commented 6 years ago

Data Format 3 Protocol Specification -> Data field descriptions -> Atmospheric Pressure: '65536' and '115536' (2x) should be '65535' and '115535'

Data Format 3 Protocol Specification -> Data field descriptions -> Battery voltage: again '65536' is out of uint16 range, should be '65535'

Data Format 5 Protocol Specification -> Data field descriptions -> Humidity: Example value '10010' when multiplied by 0.0025 results in '25.025', not '25.050' (found by my spec-based unit tests failing ;))

Data Format 5 Protocol Specification -> Data field descriptions -> Atmospheric Pressure: 'Values supported (...) 115536' should be '115535'

ojousima commented 5 years ago

I've forgotten to reply to this issue, sorry about that. It has been fixed earlier on, thanks for noting it.