search

ruuvi / ruuvi.drivers.c

Ruuvi embedded drivers used across various platforms. Used by ruuvi.firmware.c. In Beta, tests which pass will not be broken without incrementing major version.
BSD 3-Clause "New" or "Revised" License
6 stars 14 forks source link

Support Sensirion SEN55 #256

Closed TheSomeMan closed 3 months ago

ojousima commented 1 year ago

Thanks, overall looks really good. Please add the folder https://github.com/Sensirion/embedded-i2c-sen5x as a git submodule instead, it makes tracking the version of driver easier.

I have a few nitpicks, but let's look into those once the PR is ready for review.

TheSomeMan commented 1 year ago

Thanks, overall looks really good. Please add the folder https://github.com/Sensirion/embedded-i2c-sen5x as a git submodule instead, it makes tracking the version of driver easier.

I have a few nitpicks, but let's look into those once the PR is ready for review.

But we need to modify sensirion_i2c_hal.c and provide a custom implementation. So, first, do we need to clone it to Ruuvi?

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

55.5% 55.5% Coverage
2.0% 2.0% Duplication

ojousima commented 3 months ago

Closing as stale