App log remove unused fns

ruuvi / ruuvi.firmware.c

Ruuvi Firmware version 3. Built on top of Nordic SDK 15, uses both Ruuvi and external repositories as submodules. In Beta, no breaking changes are intended but may be done if absolutely necessary

BSD 3-Clause "New" or "Revised" License

54 stars 37 forks source link

App log remove unused fns #315

Closed DG12 closed 2 years ago

ojousima-jenkins commented 2 years ago

Can one of the admins verify this patch?

ojousima commented 2 years ago

ok to test

ojousima commented 2 years ago

This PR fails integration tests.

It should also be noted, that while current official Ruuvi FW does not use the app_log_config_set function, it does work and it can be used by a proprietary variant FW by calling it from main.c. Removing the functionality would break the unit tests and would require major version bump. Then we'd need to support two major version branches, the effort is not justified.