GPIO is not uninitialised on failed accelerometer initialisation, leaving floating pins

ruuvi / ruuvi.firmware.c

Ruuvi Firmware version 3. Built on top of Nordic SDK 15, uses both Ruuvi and external repositories as submodules. In Beta, no breaking changes are intended but may be done if absolutely necessary

BSD 3-Clause "New" or "Revised" License

54 stars 37 forks source link

GPIO is not uninitialised on failed accelerometer initialisation, leaving floating pins #355

Open ojousima opened 7 months ago

ojousima commented 7 months ago

Possible fixes:

Uninit GPIO on failed init
Configure pull-up / down on GPIO

DG12 commented 7 months ago

How did you discover this?

ojousima commented 7 months ago

I took off accelerometer with hot air and ran power profile

DG12 commented 7 months ago

What prompted you to do THAT ?

should this issue be in https://github.com/ruuvi/ruuvi.drivers.c ?

ojousima commented 7 months ago

What prompted you to do THAT ?

We experiment on all kinds of things ;)

should this issue be in https://github.com/ruuvi/ruuvi.drivers.c

Not really. Drivers report back to application correctly that the accelerometer was not properly initialised, problem is in main.c/app_sensor.c and app_sensor_acc_thr_set()