Double motion detect threshold, measure 1/9s in LL mode

ruuvi / ruuvi.firmware.c

Ruuvi Firmware version 3. Built on top of Nordic SDK 15, uses both Ruuvi and external repositories as submodules. In Beta, no breaking changes are intended but may be done if absolutely necessary

BSD 3-Clause "New" or "Revised" License

54 stars 37 forks source link

Double motion detect threshold, measure 1/9s in LL mode #362

Closed ojousima closed 4 months ago

sonarcloud[bot] commented 4 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

DG12 commented 4 months ago

Movement detection is too sensitive, sometimes reporting movement when none occurred.

MOTION_THRESHOLD 
was 0.064
now 0.128

Also in _longlife

NUM_REPEATS 
was 7 
now 1    ?? with this effect reliability ?

default is 2
debug   is 4

NB 
HEARTBEAT_INTERVAL is BLE_INTERVAL * NUM_REPEATS
BLE_INTERVAL 7*1285 = 9seconds

ojousima commented 4 months ago

Movement detection is too sensitive, sometimes reporting movement when none occurred.

Do you mean in this release or before? The change is intended to address motion sensitivity.

The NUM_REPEATS controls how often data is refreshed, essentially it's now 1 / s for debug, 1 / 2.5 s for default and 1 / 9 s for longline. We still need to verify the power consumption impact on all variants before we decide if we go forward with that

DG12 commented 4 months ago

My comments are intended to clarify 👍🏼 " Double motion detect threshold, measure 1/9s in LL mode"

Sorry if that caused confusion.