HTTP endpoint validation fails when 204 status code is returned

ruuvi / ruuvi.gateway_esp.c

Ruuvi Gateway ESP32 code

BSD 3-Clause "New" or "Revised" License

24 stars 15 forks source link

Closed jheba closed 1 month ago

jheba commented 1 month ago

Hi guys,

While testing https://github.com/ruuvi/ruuvi.gateway_esp.c/issues/1044 against IoT Hub HTTP endpoint, I discovered that validation fails when 204 http status code is returned.

Please consider whether 201 code should also be accepted in the validation process.

ojousima commented 1 month ago

Maybe all 2XX codes should be considered successful for validation?

jheba commented 1 month ago

+1 for all 2xx

TheSomeMan commented 1 month ago

Hi @jheba,

Could you test the fix? You can update the firmware on your gateway by using this URL (the build on Jenkins build server): https://jenkins.ruuvi.com/job/ruuvi_gateway_esp-PR/1335/artifact/build/

jheba commented 1 month ago

Works fine! Thanks!