ruuvi / ruuvi.gateway_esp.c

Ruuvi Gateway ESP32 code
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

allow HTTP URLs longer than 255 characters long #1052

Open jheba opened 4 months ago

jheba commented 4 months ago

Hello,

These days it is common that PaaS/IaaS services provide with lengthy URLs, as they often, apart of lengthy cryptic domain names and paths, contain lengthy query string parameters (for example Shared Access Signature for azure or query string authentication for AWS). Such URLs easily exceed 255 characters. I know, it can be a challenge to support extremely long URLs due to memory constrains such hardware like ruuvi gateway may have, but I believe you'll find a way.

ojousima commented 4 months ago

Do you have a current need which is blocked by URL length? One of primary goals for version 1.15 is to support third-party services such as Azure IoT Hub, AWS IoT Core and other less-known alternatives. At the same time we need to balance release schedule, reliability and memory optimisation.

If this is not an immediate blocker I'd prefer to move this issue to backlog and revisit in once we're picking tasks for v1.16.

jheba commented 4 months ago

No worries. This one is not an immediate blocker for me. P.S. I was surprised seeing misleading error message:

Validation failed
HTTP response status: 400

while the real problem was length of the URL. Once I shortened the URL, the validation worked fine.