search

ruuvi / ruuvi.gateway_esp.c

Ruuvi Gateway ESP32 code
BSD 3-Clause "New" or "Revised" License
24 stars 15 forks source link

Close #958: Handle empty response on /firmwareupate request #959

Closed TheSomeMan closed 6 months ago

ojousima commented 6 months ago

How much effort it would be to add unit tests for empty / invalid firmware update info?

TheSomeMan commented 6 months ago

How much effort it would be to add unit tests for empty / invalid firmware update info?

I think it'll take a couple of hours

TheSomeMan commented 6 months ago

Thanks, getting the test coverage to 80 % isn't strictly necessary if the tests already cover most edge cases

I added some more tests to check how updating is working for beta testers.

sonarcloud[bot] commented 6 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
82.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

TheSomeMan commented 6 months ago

@markoaamunkajo to test it you can use script ruuvi.gwui.html/scripts/http_server_auth.py, run it on your computer, then in UI on "Software Update" page enter URL in the "Server for automatic firmware updates":