ruuvi / ruuvi.gwui.html

Ruuvi Gateway web UI
BSD 3-Clause "New" or "Revised" License
5 stars 9 forks source link

Add support for configuring the scanning options #34

Closed TheSomeMan closed 3 years ago

TheSomeMan commented 3 years ago

use_coded_phy use_1mbit_phy use_extended_payload use_channel_37 use_channel_38 use_channel_39

ojousima commented 3 years ago

As a quick note, default could be

use_coded_phy = 0,
use_1mbit_phy = 1,
use_extended_payload  = 1,
use_channel_37  = 1,
use_channel_38 = 1,
use_channel_39 = 1
ojousima commented 3 years ago

Another note, currently ESP32 sends "0" on all fields to nRF52 which should mean that nRF52 doesn't scan anything at all but due to a bug in nRF52 0.5.1 FW nRF52 ends up scanning on Coded PHY only, which looks like not scanning at all unless some devices nearby happen to be using Coded PHY.

TheSomeMan commented 3 years ago

@ojousima please check my initial implementation of the scanning options: image All these settings should be displayed only when filtering is disabled, right? And could you translate these phrases into Finnish?

ojousima commented 3 years ago

Let's add a choice for "Include experimental BLE 5.0 long range sensors" for Coded PHY under "Ruuvi Sensors only".

"Which devices to scan" -> "Valitse skannattavat laitteet" "Ruuvi sensors only" -> "Vain Ruuvin anturit" "All nearby Bluetooth beacons (for advanced users)" -> "Kaikki lähistön Bluetooth-majakat (edistyneille käyttäjille)" "Use Coded PHY" -> "Skannaa virheenkorjattuja lähetyksiä" "Use 1 MBit PHY" -> "Skannaa 1 MBit lähetyksiä" "Use extended payload" -> "Skannaa pidennettyjä lähetyksiä" "Use channel XX" -> "Skannaa kanavaa XX"

TheSomeMan commented 3 years ago

@ojousima what is the Finnish translation of the phrase "Include experimental BLE 5.0 long range sensors" for Coded PHY under "Ruuvi Sensors only"?

ojousima commented 3 years ago

"Include experimental BLE 5.0 long range sensors" -> "Skannaa myös kokeellisia BLE 5.0 pitkän kantomatkan antureita"

TheSomeMan commented 3 years ago

image

image

ojousima commented 3 years ago

Looks good to me