SDK patching - Githubissues

ruuvi / ruuvitag_fw

RuuviTag firmware projects

120 stars 76 forks source link

SDK patching #3

Closed laurijamsa closed 8 years ago

laurijamsa commented 8 years ago

At the moment SDK requires some patching to compile example FW project correctly:

1) in SDK/examples/bsp/boards.h #elif defined(BOARD_CUSTOM) #include "custom_board.h" to #elif defined(BOARD_RUUVITAG_B1) #include "../../../ruuvitag_b1.h"

2) "Set the maximum number of characteristic client descriptors in the file device_manager_cnfg.h (located in \components\ble\device_manager\config):" #define DM_GATT_CCCD_COUNT 4

jrosberg commented 8 years ago

why don't use custom_board.h ?? and #ifdef RUUVITAG_HW_REV_XXX inside that? that way no patching (endless) is required.

laurijamsa commented 8 years ago

Because no custom_board.h exists...

jrosberg commented 8 years ago

how about creating one :smile:

custom_board.h

#ifdef BOARD_RUUVITAG_B1
  #include "ruuvitag_b1.h"
#endif

and defining both BOARD_CUSTOMand BOARD_RUUVITAG_B1for build ?

the SDK includes are sooooo bad... (once again)