search

rux616 / karabiner-windows-mode

Karabiner-Elements complex ruleset to make using macOS friendlier by enabling common keyboard functionality used in Linux and Windows.
The Unlicense
311 stars 66 forks source link

fix f5 in chrome #87

Closed simonLeary42 closed 3 months ago

simonLeary42 commented 3 months ago

firefox handles f5 properly out of the box, didn't check other browsers

simonLeary42 commented 3 months ago

the diff only applies to jsonnet/windows_shortcuts.jsonnet, but CI says that json/windows_shortcuts.json was changed. Not sure what to do

rux616 commented 3 months ago

It's detecting a difference between the JSON file on your branch and the one on the main branch. You should be able to fix it by just resyncing the branches to make sure you've got the latest changes from main.

github-actions[bot] commented 3 months ago

Summary of JSON file changes this PR will cause:

 json/windows_shortcuts.json | 72 +++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 72 insertions(+)

Detailed diffs:

json/windows_shortcuts.json ```diff diff --git a/json/windows_shortcuts.json b/json/windows_shortcuts.json index 79646c9..ec5462b 100644 --- a/json/windows_shortcuts.json +++ b/json/windows_shortcuts.json @@ -1353,6 +1353,46 @@ } ] }, + { + "description": "H (Ctrl) [Only Web Browsers]", + "manipulators": [ + { + "conditions": [ + { + "bundle_identifiers": [ + "^com\\.google\\.chrome$", + "^com\\.google\\.Chrome$", + "^org\\.mozilla\\.firefox$", + "^org\\.mozilla\\.nightly$", + "^com\\.brave\\.Browser$", + "^com\\.apple\\.Safari$" + ], + "type": "frontmost_application_if" + } + ], + "from": { + "key_code": "h", + "modifiers": { + "mandatory": [ + "control" + ], + "optional": [ + "any" + ] + } + }, + "to": [ + { + "key_code": "y", + "modifiers": [ + "command" + ] + } + ], + "type": "basic" + } + ] + }, { "description": "I (Ctrl)", "manipulators": [ @@ -2931,6 +2971,38 @@ "type": "basic" } ] + }, + { + "description": "F5 [Only Chrome]", + "manipulators": [ + { + "conditions": [ + { + "bundle_identifiers": [ + "^com\\.google\\.Chrome$" + ], + "type": "frontmost_application_if" + } + ], + "from": { + "key_code": "f5", + "modifiers": { + "optional": [ + "any" + ] + } + }, + "to": [ + { + "key_code": "r", + "modifiers": [ + "command" + ] + } + ], + "type": "basic" + } + ] } ], "title": "Windows Shortcuts" ```