Added filtering - Githubissues

ruyadorno / git-bc

Git plugin to interactively list branches and checkout

MIT License

60 stars 6 forks source link

Added filtering #6

Open paoloantinori opened 9 years ago

paoloantinori commented 9 years ago

Hi please consider the following aspects and test it a little before considering merging:

I'm not a .js expert and in particular I just wanted it to work for this first version!
I had to remove recently introduce support for q to quit the app, otherwise it was interfering with filtering, so technically it rolls back #5
I have bound filtering to / and ESC exits bc completely
I have forked Inquirer.js https://github.com/paoloantinori/Inquirer.js/tree/filter , because my 'filter' Prompt class is neither generic enough to expect being added upstream nor has the quality the original project has. For this reason I'm pointing to my branch on github in packages.json. If you have other strategies regarding where to put this code, I'm happy to hear your suggestions.
If you think we might start bringing the feature to a separate branch instead of going directly to master, I can re-open the PR

Fixes #4

ruyadorno commented 9 years ago

Hi @paoloantinori, thanks for all the effort, I took a quick look at the code and it's looking great.

I think it would be much better if we can extract your filter prompt into an isolated module/plugin that we can use with Inquirer.js instead - That can be amazingly useful for other projects, if we get it right even Yeoman Generators can make use of it :smile:

I'll have to find some free time to test everything, see how the plugin is working with the filtering and also to validate the possibility of extracting your filter code from the Inquirer.js fork.

I'll keep you posted.

ruyadorno commented 9 years ago

@paoloantinori Just saw this Inquirer plugin (unfortunately his implementation seems to only work for file paths) in my twitter feed and remembered about your PR, maybe it can be a good reference on how to implement your solution as a separated plugin as I have suggested before :blush:

https://github.com/Nytramr/mr-inquirer

paoloantinori commented 9 years ago

I'll have a look! I won't be quick, but I am planning to spend some time with node!

On Tue, Jul 28, 2015 at 4:50 PM, Ruy Adorno notifications@github.com wrote:

@paoloantinori https://github.com/paoloantinori Just saw this Inquirer plugin (unfortunately his implementation seems to only work for file paths) in my twitter feed and remembered about your PR, maybe it can be a good reference on how to implement your solution as a separated plugin as I have suggested before [image: :blush:]

https://github.com/Nytramr/mr-inquirer

— Reply to this email directly or view it on GitHub https://github.com/ruyadorno/git-bc/pull/6#issuecomment-125635680.