search

ruyaoyao / LineAPI4J

LineAPI for Java.
MIT License
31 stars 17 forks source link

Multiple quality improvements #10

Closed m-ezzat closed 8 years ago

m-ezzat commented 8 years ago

This pull request is focused on resolving occurrences of Sonar rules squid:HiddenFieldCheck - Local variables should not shadow class fields squid:S1192 - String literals should not be duplicated

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:HiddenFieldCheck https://dev.eclipse.org/sonar/coding_rules#q=squid:S1192

Please let me know if you have any questions.

M-Ezzat

ruyaoyao commented 8 years ago

This PR seems problematic, for instance, the charset format set to UTF-8 and it cannot be UTF_8.

m-ezzat commented 8 years ago

You can find this example in Java APIs java.nio.charset.StandardCharsets.UTF_8

ruyaoyao commented 8 years ago

Thanks, I misread some of your code.