search

ruyo / VRM4U

Runtime VRM loader for UnrealEngine4
Other
1.36k stars 176 forks source link

Maybe? Potential Typo in FVRMSceneViewExtension caused 3D Asset Thumbnail to be black in content browser after edit #355

Open reforia opened 7 months ago

reforia commented 7 months ago

Describe the bug With latest source code of the plugin, the 3D assets thumbnail will turn black in Content Browser after edited them, on Windows and Mac

Screenshots, log

image

Feels in VrmSceneViewExtension.cpp [Ln.33] The pass should be Tonemap instead of FXAA. after I changed to Tonemap it works fine. I'm not sure what's the side effect of it or if this is intended though.

void FVrmSceneViewExtension::SubscribeToPostProcessingPass(EPostProcessingPass Pass, FAfterPassCallbackDelegateArray& InOutPassCallbacks, bool bIsPassEnabled) { if (Pass == EPostProcessingPass::Tonemap) { InOutPassCallbacks.Add( FAfterPassCallbackDelegate::CreateRaw(this, &FVrmSceneViewExtension::AfterTonemap_RenderThread)); } }

UnrealEngine Version: [e.g. UE5.3.2]

Thanks!

ruyo commented 6 months ago

Hi. I've disabled the VrmSceneViewExtension because it has a lot of problems. Thanks.