search

rv-kip / express-redis-cache

A light cache system with Redis for Express
MIT License
288 stars 120 forks source link

Move redis into devDependencies #137

Open golmansax opened 2 years ago

golmansax commented 2 years ago

Fixes #130. npm test passes locally after this change. Decided against using optionalDependencies as it sounds like npm install still installs optionalDependencies. Not sure if peerDependency makes sense as it will show a warning when redis is not installed.

What do you think?

golmansax commented 2 years ago

@rawpixel-vincent This is a PR as requested for #130

demsking commented 2 years ago

redis should me moved to the peerDependencies as it's used as the main dependency by express-redis-cache