search

rvagg / github-webhook

A flexible web server for reacting GitHub Webhooks
MIT License
116 stars 24 forks source link

Doesn't actually honor the env var PORT #5

Closed mgwalker closed 8 years ago

mgwalker commented 8 years ago

The documentation says the PORT environment variable is honored, but it doesn't actually seem to. It looks like a simple typo:

else if (process.argv.PORT !== undefined)
  config.port = process.argv.PORT

should maybe be:

else if (process.env.PORT !== undefined)
  config.port = process.env.PORT

I will open a PR in just a minute!