search

rvalenciano / ngx-cron-jobs-orig

Angular > 2 version of angular-cron-jobs.
https://yp2.github.io/ngx-cron-jobs/
9 stars 10 forks source link

Default selection missing when component initialized with with a valid schedule #14

Closed Wu-Jing closed 6 years ago

Wu-Jing commented 6 years ago

Steps to reproduce:

  1. Using the app in this repo, before running the app, change freq in AppComponent to '0 ?' (Quartz) and change default service to Quartz
  2. Run the app, you can see the Set frequency (ngModel) is minute.
  3. Click on minute and select day
  4. Issue: there is no the default value selected for fields after "at"
Wu-Jing commented 6 years ago

Adding more details to step 4: since the default value is not populated, especially for non mutiple choice view, the user will see the first value in each field, but that value is actually not selected, as you can see the generate cron value is still the cron for minute. Pr created against yp2 repo.

rvalenciano commented 6 years ago

@Wu-Jing I merged the PR from yp2 repo, are we ok to close this?

Wu-Jing commented 6 years ago

Yep. I tried it and all works as expected. Thanks.