Provide ability to allow user to use config option to disable cron op…

rvalenciano / ngx-cron-jobs-orig

Angular > 2 version of angular-cron-jobs.

https://yp2.github.io/ngx-cron-jobs/

9 stars 10 forks source link

Provide ability to allow user to use config option to disable cron op… #21

Closed Wu-Jing closed 6 years ago

Wu-Jing commented 6 years ago

…tion: Minutes, Years, etc

Just like https://github.com/angular-cron-jobs/angular-cron-jobs See ###Options

Wu-Jing commented 6 years ago

@rvalenciano please let me know if you have any questions. Thanks. You can see the link mentioned above and search '###Options', or take a look at the readme file in this PR.

rvalenciano commented 6 years ago

@yp2 could you update your fork and the npm version?

Wu-Jing commented 6 years ago

Thanks guys! @rvalenciano @yp2

yp2 commented 6 years ago

Hi guys!

@Wu-Jing I think that we should not use labels in options. Labels are used on templates. Better solution is to add a field to CronJobsSelectOption with type of this filed, which then will be used in options. Also there are no test for this if branch. @Wu-Jing could you make next pull request to my repository - review will be easier.

Wu-Jing commented 6 years ago

@yp2 Thanks for the feedback. could you elaborate more on adding this to CronJobsSelectOption? As far as I understand, there is no external way to modify the array of CronJobsSelectOption (frequencies). And similarly how the js version of this implemented this feature. Thanks.