search

rvalenciano / ngx-cron-jobs-orig

Angular > 2 version of angular-cron-jobs.
https://yp2.github.io/ngx-cron-jobs/
9 stars 10 forks source link

Refactor and rewrite #8

Closed yp2 closed 6 years ago

yp2 commented 6 years ago

Refactor and rewrite of component base on angular cli project. npm packege with ng-packagr. Builds with aot. Added proper handling of ControlValueAccessor on wirteValue. Inner form build with reactive forms.

rvalenciano commented 6 years ago

Hi @yp2 , thanks for contributing, today I'll setup this locally and if everything is ok, merge it.

rvalenciano commented 6 years ago

Hey @yp2 can you send me an email (to ravf.226@gmail.com) to add you as contributor in the original project? Also I can help you with some of the pending issues you registered in the fork.

yp2 commented 6 years ago

Hi, use my GitHub profile. All help is welcome

rvalenciano commented 6 years ago

Ok, can you rebase your fork with my master? I added travis ci and code climate, maybe you should also set them up in case we continue using your repo in your profile. @yp2

yp2 commented 6 years ago

Yes I will do that. Currently I'm working on tests for CronJobsComponent.