support -N/--minSpotId and -X/--maxSpotId

rvalieris / parallel-fastq-dump

parallel fastq-dump wrapper

MIT License

265 stars 33 forks source link

support -N/--minSpotId and -X/--maxSpotId #20

Closed kfuku52 closed 5 years ago

kfuku52 commented 5 years ago

First of all, thank you for developing this fantastic tool! I recently noticed that parallel-fastq-dump automatically dumps all reads even if -N/--minSpotId and -X/--maxSpotId are specified. This PR is intended to add support for the range specification.

rvalieris commented 5 years ago

hello there, thanks for the PR.

I think it would be better if these new arguments were parsed with argparse (on the main function), instead of doing it manually. could you make these changes ?

kfuku52 commented 5 years ago

That's definitely better. Updated.

rvalieris commented 5 years ago

looks great, thanks !