rvalieris / parallel-fastq-dump

parallel fastq-dump wrapper
MIT License
275 stars 33 forks source link

an integer is required (got type _io.BufferedWriter) #34

Closed Divyoj-Singh closed 3 years ago

Divyoj-Singh commented 3 years ago

Hi I am trying to use pfd for converting sra file to fastq files in a pipeline. I have a cluster with 100 cores.following is my code: variable word1 has the SRR id.

time $path_to_parallel_fastq_dump --threads 100 --sra-id $word1 --tmpdir $path_to_sra_folder --outdir $path_to_fastq_folder$word1.fastq |& tee $path_to_stats_folder/srafastq/fout1$word1.txt

But, I am getting following error: File "/home/csb/tools/parallel-fastq-dump-master/parallel-fastq-dump", line 123, in main() File "/home/csb/tools/parallel-fastq-dump-master/parallel-fastq-dump", line 116, in main pfd(args, si, extra_args) File "/home/csb/tools/parallel-fastq-dump-master/parallel-fastq-dump", line 50, in pfd os.close(fd) TypeError: an integer is required (got type _io.BufferedWriter)

Can you please help ?

rvalieris commented 3 years ago

hello, sorry, looks like https://github.com/rvalieris/parallel-fastq-dump/pull/33 introduced a bug, to fix, replace the line: os.close(fd) to fd.close()

I will commit a fix soon.

also, --outdir $path_to_fastq_folder$word1.fastq --outdir should be a path to a directory, you don't have to add $word1.fastq in the end

Divyoj-Singh commented 3 years ago

Thanks!! Will check it out!

On Sat, Mar 13, 2021 at 5:45 PM Renan Valieris @.***> wrote:

hello, sorry, looks like #33 https://github.com/rvalieris/parallel-fastq-dump/pull/33 introduced a bug, to fix, replace the line: os.close(fd) to fd.close()

I will commit a fix soon.

also, --outdir $path_to_fastq_folder$word1.fastq --outdir should be a path to a directory, you don't have to add $word1.fastq in the end

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rvalieris/parallel-fastq-dump/issues/34#issuecomment-798268377, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIEVZECJYXJYV66UDFP7VDTDNJO3ANCNFSM4ZDPEIGQ .