search

rvanbekkum / vsc-xliff-sync

Visual Studio Code extension that allows for automatic merging of (simple) XLIFF translation files.
MIT License
23 stars 4 forks source link

Synchronize Translation Units function changes the note element closing tag #97

Closed eclipses closed 1 year ago

eclipses commented 2 years ago

Hi,

I've noted that "Synchronize Translation Units" function changes the note element closing tag

<note from="Developer" annotates="general" priority="2"></note> becomes <note from="Developer" annotates="general" priority="2"/>

If we look at the .g.xlf file generated automatically during compilation the closing tag is </note>

I verified also your corresponding function in PowerShell that does not change the closing tag. I suppose this is an issue of the VS Code extension.

warlof commented 1 year ago

I'm facing this issue myself, I hope the submitted PR would help :) I keep the current working way and provide the ability to use open/closing tags instead of self-closing ones as an alternative.

rvanbekkum commented 1 year ago

I will release this with version 1.4.0.0 today.

rvanbekkum commented 1 year ago

A new setting xliffSync.useSelfClosingTags is now available in version 1.4.0.0. Thank you again @warlof!

warlof commented 1 year ago

Thank you for your amazing extension. That already saved us a lot of time since first Business Central extensions 👌

Now we will get even less dust on pull requests including translations files 😀