search

rvanlaak / SettingsBundle

Database centric Symfony2 configuration management bundle. Global and per-entity settings supported.
MIT License
113 stars 61 forks source link

Symfony 6 compatibility #125

Closed studio-m2v closed 3 months ago

studio-m2v commented 2 years ago

Some changes to be compatible with Symfony 6 and PHP 8.x

brzuchal commented 1 year ago

@dmishh can we have this?

rvanlaak commented 1 year ago

What I am curious about is why tests do not get executed. Can you rebase on master?

dmishh commented 1 year ago

@brzuchal hey, I no longer maintain this repo. Richard is the one :) btw, @rvanlaak do you want to take over this repo? I'd like to transfer it to your account since you're maintaining it like you're the owner. Maybe some listings on the packagist will need to be updated, etc

rvanlaak commented 1 year ago

@dmishh yes please do!

But, maybe @FriendsOfSymfony or another group is even a better and more sustainable place?

dmishh commented 1 year ago

@rvanlaak I'd rather transfer to your account since you were the main contributor all the time after I stopped supporting the project. How about the packagist name or anything else required to make the transfer smooth for the users?

rvanlaak commented 1 year ago

Yes, please feel free to do so.

dmishh commented 1 year ago

@rvanlaak how about the packagist settings, etc? Should there be some changes, so it doesn't fall apart?

rvanlaak commented 1 year ago

Can you add me as maintainer on Packagist first? That way I can make sure to update the reference once the ownership on Github was transferred.

dmishh commented 1 year ago

@rvanlaak I just added you to the maintainers list - https://packagist.org/packages/dmishh/settings-bundle

rvanlaak commented 1 year ago

Feel free to transfer the repo @dmishh , thanks for your effort!

dmishh commented 1 year ago

@rvanlaak you need to delete the repo fork in your account first. The error I'm getting during the transfer attempt: "rvanlaak/SettingsBundle already exists"

Please, do so and let me know. Thanks

rvanlaak commented 1 year ago

Removed my fork ✅

dmishh commented 1 year ago

@rvanlaak great! "Repository transfer to rvanlaak requested"

Thanks for supporting the bundle!

Chris53897 commented 1 year ago

Thanks @rvanlaak for takeing over the repo. Please let us know after the transfer is completed and i hope we get symfony 6 support soon.

rvanlaak commented 1 year ago

@dmishh in order to not mess up possible packagist installations (as I was OoO for some days), I've not accepted the transfer yet and it now has expired. Can you resend it?

dmishh commented 1 year ago

@rvanlaak yep, I just initiated the transfer again

rvanlaak commented 1 year ago

Done! Updated the Packagist settings accordingly and left a note on README for clarity. Thank you @dmishh !