search

rvanlaak / SettingsBundle

Database centric Symfony2 configuration management bundle. Global and per-entity settings supported.
MIT License
113 stars 61 forks source link

feat: symfony6 #128

Open Chris53897 opened 1 year ago

Chris53897 commented 1 year ago

superseeds https://github.com/rvanlaak/SettingsBundle/pull/126 https://github.com/rvanlaak/SettingsBundle/pull/123

Chris53897 commented 1 year ago

I tried to fix the ci errors. @rvanlaak Can you please approve the ci run?

Chris53897 commented 1 year ago

The newest ci run should be green. I changed ci to run on forks. That makes it easier.

I tried to took the changes from https://github.com/rvanlaak/SettingsBundle/pull/125/ But i am not sure if i should take the changes from the following files.

This needs a real world project to test.

But i guess we need to change dmishh/settings-bundle in a lot of places to rvanlaak/settings-bundle?

@rvanlaak WDYT?

Chris53897 commented 1 year ago

Should this PR target PHP 8.1? https://github.com/rvanlaak/SettingsBundle/issues/124#issuecomment-1228267462

rvanlaak commented 1 year ago

Your PR now is doing a lot of things at the same time.

Would it be hard to not bump the PHP requirement and drop the CI tests, but to add Symfony 6 support? Would be great if we could add that as last minor release in the current 3.x branch, and finally release an actual stable version in the 3.x branch.

We could then thereafter in a new v4.x major release focus on dropping PHP < 8.1 and Symfony < 5.4 LTS support.

Chris53897 commented 1 year ago

Maybe branch the actual 3.x to 4.x and this PR will target the new 4.x Branch. The included minor changes can be repeated for 3.x. So this PR does not have to be changed, and we still can make minor releases for 3.x

rvanlaak commented 1 year ago

Would you be willing to help with making a new small PR for adding Symfony 6 support for the 3.x branch?

We can then indeed thereafter focus on making this PR fit on the newly to create 4.x branch.

Chris53897 commented 1 year ago

I have to think about this. Symfony 6 requires php > 8.0 and Symfony 6.1 php > 8.1. Symfony 6.2 is the only version with support at this time https://symfony.com/releases

User need php 8.1 to run Symfony 6.2. I do not see the need to backport all changes to 3.x. 3.x still need CI-Updates and of course security fixes.

rvanlaak commented 1 year ago

There is no hard requirement to bump the PHP requirement on a bundle to match the Symfony version.

It is perfectly fine to keep supporting PHP 7.4 with our code, and let users themselves make the decision to upgrade Symfony to v6.0 or v6.1 (and thereby possibly the PHP version).